fix(Board): make cross-board swaps source-aware - #1343
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c46b21c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📦 NPM canary releaseDeployed canary version 0.0.0-canary-32885ef. |
Contributor
🧪 Storybook is successfully deployed!
|
Contributor
🏋️ Size limit report
Compared against main at 4594454 — run 32485258255, 2026-08-21T13:07:50Z.To see which modules changed, download the size-limit-statoscope-report artifact from this run and open report.html. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes Board drag-and-drop commit semantics for cross-board transfers, including when layouts and
onWidgetTransferfire. In-board swap behavior is unchanged.Overview
Makes
collisionMode="swap"source-aware. In-board drops still exchange with one widget. Across boards (including nested → parent), swap is now strict insertion: the requested anchor must be empty, the incoming widget may downscale into room to the right/below, and destination widgets are never swapped or compacted.An occupied anchor, a fit below
minW/minH, or releasing after a valid preview onto an invalid cell cancels the transfer. Both boards restore their start snapshots; the last valid preview is not committed and no layout/transfer callbacks fire.Preview and commit now track whether the pointer actually landed at the requested cell (
targetLandingRef), so a declined collision resolution cannot be treated as a drop. Docs, stories, and tests cover the new cross-board path.Reviewed by Cursor Bugbot for commit c46b21c. Bugbot is set up for automated code reviews on this repo. Configure here.