Draft
Disable nanobind leak tracking by removing NB_STATIC flag#60
Conversation
… the same game positions
… warnings Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix nanobind reference leak warnings in pytest
Suppress nanobind module-level reference leak warnings
Feb 13, 2026
Owner
|
i dont like simply supressing the warnings. |
Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Copilot
AI
changed the title
Suppress nanobind module-level reference leak warnings
Disable nanobind leak tracking by removing NB_STATIC flag
Feb 13, 2026
ctgk
force-pushed
the
develop
branch
2 times, most recently
from
a484cb5 to
07005fa
Compare
ctgk
force-pushed
the
develop
branch
5 times, most recently
from
3ea2a14 to
401cbc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running pytest raised nanobind reference leak warnings for module-level constructs (enums, types, functions). These are documented false positives - the objects intentionally persist for the module's lifetime.
Changes
cpp/python/CMakeLists.txt: Removed
NB_STATICfrom allnanobind_add_module()calls:_vshogi_minishogi_judkins_shogi_shogiTechnical rationale
NB_STATIClinks nanobind as a static library and enables leak tracking - useful for development, but inappropriate for production code with module-level constructs. Without it, nanobind links as a shared library with leak tracking disabled at compile time.This eliminates warnings without code-level suppressions (
nb::set_leak_warnings(false)), while reducing binary size through shared library usage.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.