Draft
Remove CodeQL analysis artifact from version control#58
Conversation
Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Replace pybind11 with nanobind in project
Migrate Python bindings from pybind11 to nanobind
Feb 10, 2026
Following nanobind_example reference, modernize the build system to use scikit-build-core with CMake instead of traditional setuptools. Changes: - Updated pyproject.toml to use scikit-build-core as build backend - Created root CMakeLists.txt for Python extension building - Added scikit-build configuration with stable ABI support (cp312+) - Use nanobind_add_module for proper nanobind integration - Removed strict compile options for nanobind modules to avoid warnings - All Python modules install correctly with proper directory structure Benefits: - Modern, standard build system for Python C++ extensions - Better CMake integration and caching - Stable ABI wheels reduce distribution size - Cleaner separation of build configuration - Faster incremental builds Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
- Created comprehensive BUILD.md explaining the new build system - Added deprecation notice to setup.py - Documented scikit-build-core workflow for users and developers - Included comparison with old build system Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
- Added comment explaining Python version requirements vs stable ABI - Added comment explaining wheel.install-dir configuration - Improved code documentation for better maintainability Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Copilot
AI
changed the title
Migrate Python bindings from pybind11 to nanobind
Migrate to scikit-build-core following nanobind_example
Feb 10, 2026
Pass the nb::is_arithmetic() annotation to all nb::enum_ bindings to enable arithmetic operations and implicit integer conversions on enum types. This annotation: - Allows implicit conversions to/from integers - Enables arithmetic operations on enums - Improves interoperability with NumPy and numeric libraries - Maintains backward compatibility with existing code Changed files: - cpp/python/vshogi_wrapper.cpp: ColorEnum and ResultEnum - cpp/python/minishogi_wrapper.cpp: SquareEnum, PieceTypeEnum, PieceEnum - cpp/python/shogi_wrapper.cpp: SquareEnum, PieceTypeEnum, PieceEnum - cpp/python/judkins_shogi_wrapper.cpp: SquareEnum, PieceTypeEnum, PieceEnum All existing tests pass (142/142 in minishogi test suite). Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Copilot
AI
changed the title
Migrate to scikit-build-core following nanobind_example
Add nb::is_arithmetic() annotation to enum bindings
Feb 11, 2026
The _codeql_detected_source_root symlink is a temporary file created by GitHub CodeQL during code scanning analysis. It should not be tracked in version control. Changes: - Removed _codeql_detected_source_root from git tracking - Added _codeql_detected_source_root to .gitignore to prevent future commits This is a cleanup change with no impact on functionality. Co-authored-by: ctgk <25563881+ctgk@users.noreply.github.com>
Copilot
AI
changed the title
Add nb::is_arithmetic() annotation to enum bindings
Remove CodeQL analysis artifact from version control
Feb 11, 2026
ctgk
force-pushed
the
develop
branch
2 times, most recently
from
a484cb5 to
07005fa
Compare
ctgk
force-pushed
the
develop
branch
4 times, most recently
from
3ea2a14 to
401cbc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_codeql_detected_source_rootis a symlink created by GitHub CodeQL scanner to mark the source root during analysis. It was accidentally committed and should be ignored like other build artifacts.Changes
_codeql_detected_source_rootfrom git tracking.gitignoreto prevent future commitsThe file remains in working directories where CodeQL runs but is no longer tracked in version control.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.