Client react version#76
Conversation
art4ride
left a comment
art4ride
left a comment
There was a problem hiding this comment.
Commented out a number of issues. Will test it on my local after they'll be fixed
| @@ -0,0 +1,7 @@ | |||
| import { Clients } from '../../../imports/api/clients/clients'; | |||
|
|
|||
| export const getClientProfile = function getClientProfile(clientId) { | |||
There was a problem hiding this comment.
Seems like this is not in use. What's the purpose of that code? If you need it for testing please move it to /imports/__tests__/fixtures
| display: block !important; | ||
| } | ||
| .custom .show { | ||
| display: none !important; |
There was a problem hiding this comment.
show class with display: none seems confusing
| import { Clients } from '../../../imports/api/clients/clients'; | ||
|
|
||
|
|
||
| const reasons = [ |
There was a problem hiding this comment.
can you please move reasons to a separate file. Otherwise it will be hard to find
| }); | ||
| const clientIds = clientVersions.map(({ clientId }) => clientId); | ||
|
|
||
| const remarks = $('#removalRemarks').val(); |
There was a problem hiding this comment.
Can you please use react way of getting values instead of jQuery one?
| const clientVersions = client.clientVersions | ||
| .filter(({ clientId, schema }) => { | ||
| const data = this.getEligibleClient(clientId, schema); | ||
| if(!!(data)){ |
| .tab-section .nav-tabs.nav-justified > li.active > a:hover { | ||
| border: none; | ||
| } | ||
| .css-10nd86i { |
There was a problem hiding this comment.
please use semantic names for styling
| position: relative; | ||
| box-sizing: border-box; | ||
| } | ||
| .css-vj8t7z { |
| @@ -0,0 +1,8 @@ | |||
| <head> | |||
| <title>Home-App</title> | |||
There was a problem hiding this comment.
is this in use? We're not switching to React completely yet
| format: 'MM-DD-YYYY', | ||
| }); | ||
|
|
||
| $('body').on('click', '.tag_form_cancel', function () { |
There was a problem hiding this comment.
can you please handle those either in React or Blaze/Meteor way?
|
|
||
| export const renderRoutes = () => ( | ||
| <Router> | ||
| <Route path="/clientr/:clientId" component={ClientItem} /> |
There was a problem hiding this comment.
clientr ?
Ans we're not using react-router at the moment
2 participants
Please review code and merge if everything looks ok.