This repository was archived by the owner on Mar 31, 2021. It is now read-only.
Hipehdf5#21
Open
devine73 wants to merge 3 commits into
Open
Conversation
Member
|
Could you rename the file that it is clear that this is in this hipecta format? eg. |
Author
|
So, is it ok now ? (I updated also the tests in ctapipe with the proper file name). |
Member
|
I think this may blow the size limit of the package... This reminds me that we need to address the issue cta-observatory/ctapipe#738 soon, since ctapipe-extra has become too large. |
Member
|
How do the tests of e.g. ctapipe_io_lst, etc work? I don't think they all have example files in ctapipe-extra? |
Member
|
see cta-observatory/ctapipe#1073 -> we now have space for larger test datasets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As announced in the ASWG meeting on Thursday 9th, the HDF5 reader for the HDF5 data format from the LAPP for R1 (direct conversion from simtel file). Add the proper test file gamma_test_large.simtel.gz converted into HDF5 gamma_test_large.h5
To contact the author:
pierre.aubert@lapp.in2p3.fr