Do not use a Range as an argument to :ver - #6
Merged
Conversation
Adverbs like `:ver()` are currently not respected on the legacy grammar, so the test being changed here isn't actually enforcing any version at all. In RakuAST `require` will respect `:ver(...)`, but that results in an error when given a Range object. Maybe such Range objects will work in the future, but for now using a Version with `+` accomplishes the same thing while making it compatible with RakuAST.
Contributor
Author
|
ping @dwarring |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adverbs like
:ver()are currently not respected on the legacy grammar, so the test being changed here isn't actually enforcing any version at all. In RakuASTrequirewill respect:ver(...), but that results in an error when given a Range object. Maybe such Range objects will work in the future, but for now using a Version with+accomplishes the same thing while making it compatible with RakuAST.