Support simultaneous RSYS and ideal hvac#626
Merged
Merged
Conversation
Contributor
|
@chipbarnaby any other changes needed here before review? |
Contributor
Author
|
Additional features such as efficiency and meter links are not done.
Some documentation is probably needed.
We could decide upon an intermediate stopping point and then merge.
…On Thu, May 7, 2026 at 7:11 PM Neal Kruis ***@***.***> wrote:
*nealkruis* left a comment (cse-sim/cse#626)
<#626 (comment)>
@chipbarnaby <https://github.com/chipbarnaby> any other changes needed
here before review?
—
Reply to this email directly, view it on GitHub
<#626 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWGW7GYQJCLLKFCQP2CZVL4ZUJZ5AVCNFSM6AAAAACYFRETLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIMBRHAZTIMJSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
@chipbarnaby do we want to try to get a version of this in the next release? I think there are just a few documentation tasks left here? We might make an issue documenting follow up steps (e.g., meter + efficiency). |
nealkruis
requested changes
Jul 1, 2026
nealkruis
left a comment
nealkruis
left a comment
Contributor
There was a problem hiding this comment.
Minor changes suggested.
Comment on lines
+1146
to
+1150
| #if 0 && defined( _DEBUG) | ||
| if (Top.jDay == 256 && Top.iHr == 23 && Top.iSubhr > 10) | ||
| printf("\nHit"); | ||
| #endif | ||
|
|
| Heating capacity at current conditions | ||
| Ideal sensible heating capacity for current hour. If at the end of a simulation step the air temperature in a conditioned zone is below znTH after contributions from any other systems such as RSYS, additional heat is added (up to znQMxH) to hold the zone at the setpoint. No mechanical equipment or delivery air flow are modeled. | ||
|
|
||
| Added heat is accumulated to ZNRES qshIdeal and to qHtg of the LOADMETER specified in znLoadMtr (if any). |
Contributor
There was a problem hiding this comment.
Maybe link to the ZNRES probes and make it explicit that you're talking about the probe here?
Comment on lines
+3822
to
+3826
| #if 0 && defined( _DEBUG) | ||
| float effX = abs(R.qcSen + R.qcLat) / max(R.ecPrimary, .001f); | ||
| if (frDiff(rs_effCt, effX) > 0.01f) | ||
| printf("\nMismatch"); | ||
| #endif |
Contributor
|
Also, @chipbarnaby, should we use this branch to improve on the documentation mentioned in #589? |
nealkruis
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow both RSYS and ideal HVAC to serve a zone. This allows determination of energy required to hold zone setpoints when RSYS capacity is insufficient.
Updated documentation re this feature.
Update regression tests to use and report ideal heating / cooling.