Skip to content

Fix path serialization in form request#457

Merged
hendraet merged 3 commits into
devfrom
fix-path-serialization-in-form-request
Jun 18, 2026
Merged

Fix path serialization in form request#457
hendraet merged 3 commits into
devfrom
fix-path-serialization-in-form-request

Conversation

@hendraet

Copy link
Copy Markdown
Collaborator

Description

Form fields were not able to properly serialize paths when get_step_form was called. The CustomEncoder was updated to also include paths. I also added some tests that should fail if future code adds data types to fields that cannot natively be serialized for JSON.

Testing

Create a workflow that contains a step, which uses a file upload (e.g., PTM Visualization: Bar Plot). After uploading a file, it should be possible to navigate away and back to the step again, which led to an error before.

PR checklist

Development

  • If necessary, I have updated the documentation (README, docstrings, etc.)
  • If necessary, I have created / updated tests.

Mergeability

  • dev-branch has been merged into local branch to resolve conflicts
  • The tests and linter have passed AFTER local merge
  • The backend code has been formatted with black
  • The frontend code has been formatted with pnpm format and checked with pnpm lint

Code review

  • I have self-reviewed my code.
  • At least one other developer reviewed and approved the changes

@github-actions

Copy link
Copy Markdown

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  backend/protzilla
  form.py
Project Total  

This report was generated by python-coverage-comment-action

@Elena-kal Elena-kal self-requested a review June 18, 2026 09:06

@Elena-kal Elena-kal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and it works. Nice :))

@hendraet hendraet merged commit fd4b0d3 into dev Jun 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants