Return proper error codes instead of NewInternal - #5781
Open
btwshivam wants to merge 7 commits into
Open
Conversation
Signed-off-by: btwshivam <shivam.devline@gmail.com>
Signed-off-by: btwshivam <shivam.devline@gmail.com>
Signed-off-by: btwshivam <shivam.devline@gmail.com>
Signed-off-by: btwshivam <shivam.devline@gmail.com>
Signed-off-by: btwshivam <shivam.devline@gmail.com>
btwshivam
force-pushed
the
review-internal-errors
branch
from
August 17, 2026 23:50
f41ab60 to
dddcf2a
Compare
Signed-off-by: btwshivam <shivam.devline@gmail.com>
Signed-off-by: btwshivam <shivam.devline@gmail.com>
btwshivam
marked this pull request as ready for review
August 19, 2026 20:07
btwshivam
requested review from
diocas,
glpatcern,
jessegeens and
rawe0
as code owners
August 19, 2026 20:07
Contributor
Author
|
@glpatcern Please take a look when you get a chance :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4915.
NewInternal()was used as a catch-all across the grpc services and flattened errors that already carried a code (notfound, permission denied, ...) into INTERNAL. routes those throughNewStatusFromErrTypeso the real code reaches the client, adds the inverseNewErrtypeFromStatusfor the gateway helpers that receive a downstream status and fixes a few miscoded BadRequestsalso i see there are genuinely internal sites (transport failures, marshaling, client setup) i left them as-it-is