Report failures on COPY and third-party copy instead of success - #5774
Open
btwshivam wants to merge 3 commits into
Open
Report failures on COPY and third-party copy instead of success#5774btwshivam wants to merge 3 commits into
btwshivam wants to merge 3 commits into
Conversation
Signed-off-by: btwshivam <shivam.devline@gmail.com>
Signed-off-by: btwshivam <shivam.devline@gmail.com>
Signed-off-by: btwshivam <shivam.devline@gmail.com>
btwshivam
requested review from
diocas,
glpatcern,
jessegeens and
rawe0
as code owners
August 16, 2026 18:07
Contributor
Author
|
@glpatcern @jessegeens PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COPY handler and the third-party copy push/pull handlers reported success even when the upload to the data server (or the remote PUT) returned a non-2xx status. For overwrite COPY the destination is deleted before the upload, so a false success silently lost the file, for a third-party copy a transfer manager could delete the source after a copy that never actually happened.
While in there, a third-party copy push of a source that doesn't exist dereferenced a nil stat result and panicked.. it now returns 404
Now its: