Skip to content

Upgrades + silence - #1

Merged
dumbasPL merged 9 commits into
cs2-analysis:masterfrom
Axwabo:master
Apr 18, 2026
Merged

Upgrades + silence#1
dumbasPL merged 9 commits into
cs2-analysis:masterfrom
Axwabo:master

Conversation

@Axwabo

@Axwabo Axwabo commented Apr 17, 2026

Copy link
Copy Markdown
Contributor
  • Upgraded the action to run on node24 as node20 is now deprecated
  • Upgraded some packages with npm audit fix
  • Changed the test function to only output text if debug logging is enabled

@Axwabo

Axwabo commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

At the moment, I set test to be true by default. Should this changed to be false?

@dumbasPL

Copy link
Copy Markdown
Contributor

At the moment, I set test to be true by default. Should this changed to be false?

How about simply redirecting the output to a buffer and only printing it if it fails? This way, we get the best of both worlds. I don't see the point in skipping it; it's basically instant anyway.

I don't really see the point in getting rid of the log either, it's not like github charges extra for them, but I don't have anything against hiding them when there is no error.

Up to you

Comment thread README.md
@Axwabo

Axwabo commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

Should the "silent" logging be optional?

@dumbasPL

Copy link
Copy Markdown
Contributor

Should the "silent" logging be optional?

You can just use the built-in GitHub debug logging. If there is no error, print it there. Then it won't be visible by default unless the user re-runs the action with debug logging enabled

@Axwabo Axwabo changed the title Upgrades + test input option Upgrades + silence Apr 17, 2026
@Axwabo
Axwabo requested a review from dumbasPL April 17, 2026 12:45
@Axwabo

Axwabo commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

I have successfully fallen into the dist trap, would you like me to build and push dist in this PR?

@dumbasPL

Copy link
Copy Markdown
Contributor

I have successfully fallen into the dist trap, would you like me to build and push dist in this PR?

yes

@dumbasPL dumbasPL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dumbasPL
dumbasPL merged commit aeba3c5 into cs2-analysis:master Apr 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants