software-stack/libc/drills: Fix extra closing brace caused by incorrect TODO marker - #225
Closed
BobiPatrunjel wants to merge 2 commits into
Closed
software-stack/libc/drills: Fix extra closing brace caused by incorrect TODO marker#225BobiPatrunjel wants to merge 2 commits into
BobiPatrunjel wants to merge 2 commits into
Conversation
During the build process, an extra line was removed from the source file, which caused the closing brace of a function to be deleted. This resulted in a syntax error and prevented the code from compiling correctly. The issue was caused by an incorrect TODO marker in named_pipe.c. This commit fixes the problem by changing the comment from TODO 9 to TODO 8, ensuring the make process no longer removes the closing brace. Signed-off-by: Roberto Tarapoanca <roberto.tarapoanca@stud.acs.upb.ro>
…ns task During the build process, an extra closing brace remained in the source file, which caused a compilation error. The issue was caused by an incorrect TODO marker in os_string.c. This commit fixes the problem by changing the comment from TODO 25 to TODO 26, ensuring the generated code no longer contains an extra closing brace. Signed-off-by: Roberto Tarapoanca <roberto.tarapoanca@stud.acs.upb.ro>
BobiPatrunjel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite Checklist
Description of changes
This pull request fixes a build issue in the common functions task where an
extra closing brace (
}) remained in the generated source code, causing acompilation error.
The issue was caused by an incorrect TODO marker in
chapters/software-stack/libc/drills/tasks/common-functions/solution/src/os_string.c.
Changing the comment from TODO 25 to TODO 26 removes the extra closing brace
and restores correct compilation.