Fix Fire charge cast direction rotation on rotated cameras#311
Open
Dragometh wants to merge 4 commits into
Open
Fix Fire charge cast direction rotation on rotated cameras#311Dragometh wants to merge 4 commits into
Dragometh wants to merge 4 commits into
Conversation
TheShuEd
reviewed
Jun 21, 2026
|
|
||
| - type: entity | ||
| parent: CEBaseMagicImpact | ||
| id: CEBaseMagicImpactAlt |
Contributor
There was a problem hiding this comment.
Maybe something more descriptional, like Directional
Author
There was a problem hiding this comment.
was using the description as the comment specifying that, but yeah that makes more sense
TheShuEd
reviewed
Jun 22, 2026
| - type: entity | ||
| id: CEEffectFireballCharge | ||
| parent: CEBaseMagicImpact | ||
| parent: CEBaseMagicImpactAlt |
Author
There was a problem hiding this comment.
yeah that was a dumb mistake of mine, very silly of me to let it go through. one sec, fixing
(also sorry for the absence, it was my last week of a euro trip so I was spending last week touching grass)
TheShuEd
reviewed
Jun 22, 2026
| - type: entity | ||
| id: CEEffectFireboltCharge | ||
| parent: CEBaseMagicImpact | ||
| parent: CEBaseMagicImpactAlt |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
removes out a
noRot: trueon the mutual parent of both affected skillsWhy / Balance
noRot was causing the initial fire charge from both the firebolt and firewall skills to apply to weird rotations in case the camera was rotated in any way (see #173)