Health examination#310
Open
Dragometh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
brings in a modified version of ss14 health examination adapted to work with CE's components;
lets you examine other mobs' health
important thing to point that might not be desired:
I've modified a bit how
HealthInfo'sRatiovariable is computed;now, regardless of if player is on crit or not, it'll be a value between 0 to 1. if player is not on crit, uses
currentHp/maxHplike before; if they are crit, however, it returns1f - ((float)damage.Damage.Total - maxHp) / destroyThreshold.Value), which is their remaining hp ratio until they are dead for real.I've checked other uses of this
ratiovariable, and this probably shouldn't break anything, since they are only used out of crit and the math for ratio while player is out of crit remains unchanged; if anything, we can now make other systems simplified using this.Why / Balance
to see how badly friend is beaten up is a good thing
Media
(to-do)
Changelog
🆑