feat(release): Require previous beta upgrade evidence#1370
Merged
leumor merged 12 commits intoJun 29, 2026
Conversation
Keep repository Gradle defaults in gradle.properties.example and install them into Gradle User Home for CI jobs. This lets local gradle.properties remain machine-specific while preserving strict verification and daemon settings in automated runs.
Read current production catalog editions from previousCandidateMetadata.catalog when attached to the multi-node upgrade drill. Fail attached current summaries that omit catalog editions instead of synthesizing a previous+1 value, and update production beta self-test fixtures to match the emitted summary shape.
Apply production-style public artifact URI validation when strict previous beta candidate summaries are verified. Also avoid printing unsupported JSON field names so malformed summaries cannot leak secret-looking keys into logs.
Reject mismatched previous-summary source identities before generating normalized previous beta candidate evidence. In production-beta mode, require the supplied or restored previous release-certification history summary to match the digest and available identity recorded in the previous candidate summary. Add self-test coverage for mismatched source summaries, stale explicit history, and stale restored history.
Install Gradle defaults before dependency submission so CI dependency graph generation keeps strict dependency verification. Require exact pass statuses when validating previous beta candidate summaries so strict production validation matches the generated schema.
Reject future-dated previous beta candidate summaries when production freshness validation is active. Fail attached current production summaries whose selected catalog channel edition does not advance beyond the previous candidate.
Bind production-beta multi-node upgrade evidence to the current release version before promotion. Inject the verified previous-candidate summary into generated multi-node soak configs so runner-local restored inputs are used. Restore tracked root Gradle defaults so local wrapper runs and CI setup keep strict dependency verification.
Validate artifact URI authority syntax before accepting production release evidence. Reject malformed hosts, empty or invalid ports, and invalid DNS labels for previous-candidate summaries and current artifact bases.
Require production-beta previous-candidate upgrade evidence to match the current run's catalog channel and edition. Reject attached multi-node summaries from stale or wrong-channel catalog runs before marking promotion ready.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a591535d04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reject attached multi-node previous-candidate upgrade evidence when its current version, catalog channel, or catalog edition does not match the production beta summary being evaluated. Update the pass fixture to describe the current 270 candidate and cover stale upgrade evidence with dashboard self-tests.
Refresh rejects same-timestamp catalog bytes with a different content digest as ambiguous. Advance the catalog refresh fixture timestamp so the integration test exercises a valid newer revision. This fixes the PlatformApiAppsIntegrationTest refresh path that returned 502 in CI.
|
leumor
deleted the
feature/public-beta-upgrade-path-from-previous-candidate
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
How to test
./gradlew spotlessApplygit diff --checkpython3 -m py_compile tools/release-certification/production_beta_release.py tools/release-certification/multi_node_beta_soak.pypython3 tools/release-certification/production_beta_release.py --self-testpython3 tools/release-certification/multi_node_beta_soak.py --self-testNotes
No local pull request template was present in the repository when this PR was created.