Skip to content

fix(deps): downgrade dependency io.quarkiverse.quinoa:quarkus-quinoa to v2.8.3 - #1726

Merged
andrewazores merged 1 commit into
cryostatio:mainfrom
andrewazores:downgrade-quinoa
Aug 7, 2026
Merged

fix(deps): downgrade dependency io.quarkiverse.quinoa:quarkus-quinoa to v2.8.3#1726
andrewazores merged 1 commit into
cryostatio:mainfrom
andrewazores:downgrade-quinoa

Conversation

@andrewazores

@andrewazores andrewazores commented Aug 7, 2026

Copy link
Copy Markdown
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


This reverts commit 9ed0a92 (#1724), which is causing build failures.

Summary by CodeRabbit

  • Chores
    • Updated the Quarkus Quinoa integration version to 2.8.3.

@andrewazores
andrewazores requested a review from a team as a code owner August 7, 2026 19:26
@andrewazores andrewazores added dependencies Pull requests that update a dependency file fix safe-to-test labels Aug 7, 2026
@andrewazores

Copy link
Copy Markdown
Member Author

/build_test

@github-actions github-actions Bot added the needs-triage Needs thorough attention from code reviewers label Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

Workflow started at 8/7/2026, 3:26:58 PM. View Actions Run.

@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Aug 7, 2026
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d98c2d68-da8a-4350-86eb-3dbe835ebe6a

📥 Commits

Reviewing files that changed from the base of the PR and between e019534 and 0d3966c.

📒 Files selected for processing (1)
  • pom.xml

📝 Walkthrough

Walkthrough

The Maven build property quarkus-quinoa.version changes from 2.8.4 to 2.8.3.

Changes

Quarkus Quinoa version

Layer / File(s) Summary
Update Quarkus Quinoa build property
pom.xml
The quarkus-quinoa.version property changes from 2.8.4 to 2.8.3.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ebaron

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the revert and build failure, but it omits the required issue reference, change description, motivation, and manual test sections. Add the required Fixes reference, change description, motivation, and manual testing steps.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the dependency downgrade to version 2.8.3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

No OpenAPI schema changes detected.

No GraphQL schema changes detected.

WebSocket notifications schema change detected:

diff --git a/schema/notifications.yaml b/schema/notifications.yaml
index b263685..bce6681 100644
--- a/schema/notifications.yaml
+++ b/schema/notifications.yaml
@@ -1081,43 +1081,39 @@ components:
             properties:
               event:
                 type: object
                 properties:
                   kind:
                     type: object
                     description: Payload of type EventKind
                   serviceRef:
                     type: object
                     properties:
-                      id:
-                        type: integer
                       connectUrl:
                         type: object
                         description: Payload of type URI
                       alias:
                         type: string
                       jvmId:
                         type: string
                       labels:
                         type: object
                         additionalProperties: true
                       annotations:
                         type: object
                         properties:
                           platform:
                             type: object
                             additionalProperties: true
                           cryostat:
                             type: object
                             additionalProperties: true
-                      agent:
-                        type: boolean
                   jvmId:
                     type: string
         required:
         - meta
         - message
     TemplateDeleted:
       name: TemplateDeleted
       title: Template Deleted
       summary: 'Notification: TemplateDeleted'
       description: WebSocket notification for Template Deleted events

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
https://github.com/cryostatio/cryostat/actions/runs/31211493818

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

CI build:
Unit tests pass ✅
Tests run: 720, Failures: 0, Errors: 0, Skipped: 4
https://github.com/cryostatio/cryostat/actions/runs/31211493818

@mergify

mergify Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@andrewazores
andrewazores merged commit 0863f21 into cryostatio:main Aug 7, 2026
34 of 35 checks passed
@andrewazores
andrewazores deleted the downgrade-quinoa branch August 7, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file fix safe-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants