Skip to content

feat(unified-logs): implement management and collection of JVM unified logs - #1710

Merged
andrewazores merged 34 commits into
cryostatio:mainfrom
andrewazores:gc-logs
Jul 30, 2026
Merged

feat(unified-logs): implement management and collection of JVM unified logs#1710
andrewazores merged 34 commits into
cryostatio:mainfrom
andrewazores:gc-logs

Conversation

@andrewazores

@andrewazores andrewazores commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #1367
Based on #1699 to allow Agent-based GC log collection unit tests
Depends on #1699
Depends on cryostatio/cryostat-agent#973

Description of the change:

This change allows an environment variable to be configured so that...

Motivation for the change:

This change is helpful because users may want to...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... bash smoketest.bash...
  2. ...

@andrewazores andrewazores added feat New feature or request safe-to-test labels Jul 22, 2026
@github-actions github-actions Bot added dependent needs-triage Needs thorough attention from code reviewers labels Jul 22, 2026
@andrewazores andrewazores removed the needs-triage Needs thorough attention from code reviewers label Jul 22, 2026
@andrewazores andrewazores mentioned this pull request Jul 22, 2026
Merged
7 tasks
@andrewazores

andrewazores commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

/build_test

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Workflow started at 7/23/2026, 9:58:07 AM. View Actions Run.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

OpenAPI schema change detected:

diff --git a/schema/openapi.yaml b/schema/openapi.yaml
index 6786761..5fdfcfb 100644
--- a/schema/openapi.yaml
+++ b/schema/openapi.yaml
@@ -516,20 +516,22 @@ components:
           type: integer
       type: object
     GcLogStatus:
       properties:
         decorators:
           type: string
         enabled:
           type: boolean
         hasLog:
           type: boolean
+        what:
+          type: string
       type: object
     GitInfo:
       properties:
         hash:
           type: string
       type: object
     HeapDump:
       properties:
         downloadUrl:
           type: string

No GraphQL schema changes detected.

No WebSocket notifications schema changes detected.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
https://github.com/cryostatio/cryostat/actions/runs/30013587318

@andrewazores

andrewazores commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

/build_test

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

Workflow started at 7/23/2026, 6:14:59 PM. View Actions Run.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

No OpenAPI schema changes detected.

No GraphQL schema changes detected.

No WebSocket notifications schema changes detected.

@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
https://github.com/cryostatio/cryostat/actions/runs/30049206325

@andrewazores
andrewazores force-pushed the gc-logs branch 4 times, most recently from 284f54a to b0f5df8 Compare July 27, 2026 19:01
@andrewazores
andrewazores marked this pull request as ready for review July 28, 2026 19:25
@andrewazores
andrewazores requested a review from a team July 28, 2026 19:25
This was referenced Jul 29, 2026
Merged
Merged
Merged
jtolentino1
jtolentino1 previously approved these changes Jul 29, 2026
View reviewed changes
@andrewazores andrewazores changed the title feat(gc-logs): implement management and collection of GC logs feat(unified-logs): implement management and collection of JVM unified logs Jul 29, 2026
@andrewazores

andrewazores commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

@jtolentino1 everything is renamed and adjusted for the feature rename from GC Logging to Unified Logging, I think.

jtolentino1
jtolentino1 previously approved these changes Jul 30, 2026
View reviewed changes
@andrewazores

andrewazores commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

/build_test

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

This PR/issue depends on:

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

Workflow started at 7/30/2026, 10:21:57 AM. View Actions Run.

@mergify

mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

No OpenAPI schema changes detected.

No GraphQL schema changes detected.

WebSocket notifications schema change detected:

diff --git a/schema/notifications.yaml b/schema/notifications.yaml
index b263685..bce6681 100644
--- a/schema/notifications.yaml
+++ b/schema/notifications.yaml
@@ -1081,43 +1081,39 @@ components:
             properties:
               event:
                 type: object
                 properties:
                   kind:
                     type: object
                     description: Payload of type EventKind
                   serviceRef:
                     type: object
                     properties:
-                      id:
-                        type: integer
                       connectUrl:
                         type: object
                         description: Payload of type URI
                       alias:
                         type: string
                       jvmId:
                         type: string
                       labels:
                         type: object
                         additionalProperties: true
                       annotations:
                         type: object
                         properties:
                           platform:
                             type: object
                             additionalProperties: true
                           cryostat:
                             type: object
                             additionalProperties: true
-                      agent:
-                        type: boolean
                   jvmId:
                     type: string
         required:
         - meta
         - message
     TemplateDeleted:
       name: TemplateDeleted
       title: Template Deleted
       summary: 'Notification: TemplateDeleted'
       description: WebSocket notification for Template Deleted events

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
https://github.com/cryostatio/cryostat/actions/runs/30551314741

@andrewazores

andrewazores commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

/build_test

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

Workflow started at 7/30/2026, 11:41:21 AM. View Actions Run.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
https://github.com/cryostatio/cryostat/actions/runs/30557900224

@andrewazores

andrewazores commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

@jtolentino1 fixed up tests

@andrewazores

andrewazores commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

/build_test

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

Workflow started at 7/30/2026, 12:12:22 PM. View Actions Run.

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

No OpenAPI schema changes detected.

No GraphQL schema changes detected.

WebSocket notifications schema change detected:

diff --git a/schema/notifications.yaml b/schema/notifications.yaml
index b263685..bce6681 100644
--- a/schema/notifications.yaml
+++ b/schema/notifications.yaml
@@ -1081,43 +1081,39 @@ components:
             properties:
               event:
                 type: object
                 properties:
                   kind:
                     type: object
                     description: Payload of type EventKind
                   serviceRef:
                     type: object
                     properties:
-                      id:
-                        type: integer
                       connectUrl:
                         type: object
                         description: Payload of type URI
                       alias:
                         type: string
                       jvmId:
                         type: string
                       labels:
                         type: object
                         additionalProperties: true
                       annotations:
                         type: object
                         properties:
                           platform:
                             type: object
                             additionalProperties: true
                           cryostat:
                             type: object
                             additionalProperties: true
-                      agent:
-                        type: boolean
                   jvmId:
                     type: string
         required:
         - meta
         - message
     TemplateDeleted:
       name: TemplateDeleted
       title: Template Deleted
       summary: 'Notification: TemplateDeleted'
       description: WebSocket notification for Template Deleted events

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

CI build:
Integration tests pass ✅
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0
https://github.com/cryostatio/cryostat/actions/runs/30560362185

@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown

CI build:
Unit tests pass ✅
Tests run: 720, Failures: 0, Errors: 0, Skipped: 4
https://github.com/cryostatio/cryostat/actions/runs/30560362185

@andrewazores
andrewazores merged commit 719b9c3 into cryostatio:main Jul 30, 2026
15 of 16 checks passed
@andrewazores
andrewazores deleted the gc-logs branch July 30, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtolentino1 jtolentino1 jtolentino1 approved these changes

Assignees

No one assigned

Labels

feat New feature or request safe-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request] GC log support

2 participants

@andrewazores @jtolentino1