fix(gc): clean up tracking entities after operation completes - #1709
Merged
Conversation
Member
Author
|
/build_test |
|
Workflow started at 7/27/2026, 10:20:53 AM. View Actions Run. |
|
No OpenAPI schema changes detected. No GraphQL schema changes detected. No WebSocket notifications schema changes detected. |
|
CI build: |
|
CI build: Flaky tests:
|
jtolentino1
approved these changes
Jul 27, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
7 tasks
andrewazores
added a commit
that referenced
this pull request
Jul 27, 2026
(cherry picked from commit 011fce5)
andrewazores
added a commit
that referenced
this pull request
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #1708
Description of the change:
Ensures that the
GarbageCollectionentity is deleted after agcrequest completes. This entity is only intended to trackgcinvocations for the audit log - the entity doesn't encode any information or even carry any specific metadata than the universal audit log metadata (timestamp, link to target ID, name of requesting client/user). Prior to this change both the primary GarbageCollection table and its GarbageCollection_AUD audit log would gain/retain a new row each time a GC request was serviced. The primary table should generally be empty in this case and only the audit log should retain a historical log.This also adds an event listener to catch target loss and ensure that no dangling ThreadDump, HeapDump, or AsyncProfilerRecording tracking entities are left behind. These already do normally have a deletion in their lifecycle, but if the associated target is unexpectedly lost while an operation is underway then the tracking entities could be left behind stale forever.