popup menu for multi-reference bookmark navigation (#crossref)#1335
Open
LAfricain wants to merge 1 commit into
Open
popup menu for multi-reference bookmark navigation (#crossref)#1335LAfricain wants to merge 1 commit into
LAfricain wants to merge 1 commit into
Conversation
Add a user-controlled option for navigating multi-reference bookmarks: - When a bookmark key contains multiple references (semicolons, commas, or verse ranges), the user can choose between two behaviours via a new 'Open cross-references in a popup menu' toggle in the bookmark context menu. - When enabled (checked): a popup menu lists each reference individually; clicking one navigates directly to that verse. Verse ranges (e.g. Mt 15:1-9) are displayed with their full label but navigate to the first verse of the range. - When disabled (unchecked): the full key is passed to main_url_handler which displays all references in the Verse List as before. - Single references and studypad bookmarks are unaffected. - The preference is saved to and restored from the Xiphos config file under misc/crossref_popup (default: 0 = verse list behaviour).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a user-controlled option for navigating multi-reference bookmarks:
When a bookmark key contains multiple references (semicolons, commas, or verse ranges), the user can choose between two behaviours via a new 'Open cross-references in a popup menu' toggle in the bookmark context menu.
When enabled (checked): a popup menu lists each reference individually; clicking one navigates directly to that verse. Verse ranges (e.g. Mt 15:1-9) are displayed with their full label but navigate to the first verse of the range.
When disabled (unchecked): the full key is passed to main_url_handler which displays all references in the Verse List as before.
Single references and studypad bookmarks are unaffected.
The preference is saved to and restored from the Xiphos config file under misc/crossref_popup (default: 0 = verse list behaviour).