Repository navigation
ci: pin actions/checkout to v7.0.1, which runs on Node.js 24 - #33
Merged
Merged
Conversation
GitHub's runners annotated every job: the pinned checkout targeted Node.js 20, which GitHub deprecates and forces onto Node.js 24. v7.0.1 targets Node.js 24 itself. The pin stays a commit hash, with persist-credentials false, in all three checkout steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub's runners annotated every job of the first runs on the hosted runners (PR #21): the pinned
actions/checkoutcommit (11d5960a, tag v4.4.0) targets Node.js 20, which GitHub deprecates and now forces onto Node.js 24. Refs #23.What changed
.github/workflows/tests.yml(two checkout steps) and.github/workflows/model-smoke.yml(one):actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1, still a commit hash, stillpersist-credentials: false. The commit is tag v7.0.1 on actions/checkout's own main and its action.yml declaresusing: node24; between v4.4.0 and v7.0.1 the action's inputs and defaults are unchanged, and the v7 behaviour changes (fork checkout underpull_request_target, credentials file location) do not touch these workflows.The issue's second item, the
ubuntu-latestlabel moving to Ubuntu 26 from 2026-10-19, needs no change now and can only be checked on the first run after that date, so this PR does not close #23.Tests run
python -m unittest tests.python.test_workflowson the branch: passes (the test still finds each checkout step before the first compose command).paths:list, the model smoke run, which is the only exercise of the new pin in that workflow.Review
Independent review: no blocking findings. It verified the tag, the commit's origin, the Node runtime and the release notes from v5.0.0 to v7.0.1. Non-blocking, filed as issues: nothing tests that every action is pinned by a 40-hex commit with
persist-credentials: falseon checkouts; no Dependabot configuration keeps the pins current.