Add logic to detect and handle circular loops, and optionally ignore deprecated fields#36
Open
brendan-morin wants to merge 4 commits into
Open
Add logic to detect and handle circular loops, and optionally ignore deprecated fields#36brendan-morin wants to merge 4 commits into
brendan-morin wants to merge 4 commits into
Conversation
Author
|
@crflynn Please let me know what your thoughts are on adding this functionality, or if there's any additional changes you'd like to see. |
Owner
|
We would probably want to change some things here since I see you added logic to Also as you mention there are no tests. Getting set up should be straightforward if you have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add options for creating spark struct to ignore circularly defined fields and/or deprecated fields. This PR is a no-op change, meaning existing behavior should not be impacted.
I was not able to get the tests up and running on my local fork (make gen and make test both gave errors), so these will need to have tests added to validate behavior is as expected. I was able to informally validate behavior is as expected in a notebook. You may also want to further configure logging, but I think that's out of scope for this PR.
It may be worth separating the recursive functionality of
get_spark_schemafrom the public interface to avoid the need to surface_seen_descriptorspublicly (e.g. keep the current entry point and hide the recursion behind something like_ get_spark_schema)