fix(brightdata): drop stray $ in f-string search URLs - #7317
Closed
simpleqt wants to merge 1 commit into
Closed
Conversation
get_search_url interpolated ${query} inside an f-string, producing
URLs like https://www.bing.com/search?q=$test — the literal $ is kept
and the query is interpolated as intended. The URL is passed straight
to the SERP request, so every search hit the wrong query string.
Contributor
|
Thanks for the pull request. First-time contributors need an associated open issue before we can review a PR.
See the contributing guide. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Bright Data SERP tool now inserts the query directly into Yandex, Bing, and Google search URLs. ChangesSearch URL interpolation
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BrightDataSERPTool.get_search_urlbuilt its URLs with${query}inside f-strings:In an f-string,
$is a literal character, so the result is...?q=$test— a malformed query string. The URL is passed directly to the SERP request (no template substitution happens later), so every search through the tool carried the stray$.The three URL templates (yandex/bing/google) now interpolate
{query}normally.(Note: this PR was prepared with AI assistance — happy to see it labeled
llm-generatedper the contributing guidelines.)