test(tools): run wait async tests with anyio (#7305) - #7307
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe wait tool tests now use AnyIO with an asyncio backend. Both async tests allow localhost network access and replace the ChangesWait tool test execution
Merge Risk: ⚪ Minimal · up to The asynchronous WaitTool tests now run through AnyIO using the asyncio backend, with loopback access allowed for Windows event-loop initialization. This is test-only configuration and presents no remaining merge-blocking product risk. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Disclosure: this is an AI-assisted contribution. I attempted to add the required |
a3cfdd7 to
b0746c0
Compare
|
This isn't the right fix for #7305. Switching two tests to The right downstream command is |
|
Thanks for the careful review and for clarifying that CrewAI’s test suite remains on pytest-asyncio. I appreciate the concrete direction. |
Related issue
Fixes #7305
Summary
WaitTool.arun()usesasyncio.sleepVerification
Commands:
uv run pytest --override-ini "addopts=" --disable-plugin-autoload -p anyio.pytest_plugin -p pytest_recording.plugin lib/crewai-tools/tests/tools/wait_tool_test.py -q(23 passed)uv run pytest lib/crewai-tools/tests/tools/wait_tool_test.py -q(23 passed)uv run ruff check --isolated lib/crewai-tools/tests/tools/wait_tool_test.pyuv run ruff format --check --isolated lib/crewai-tools/tests/tools/wait_tool_test.pyAdditional context
This is an AI-assisted contribution. I attempted to apply the required
llm-generatedlabel, but GitHub does not grant external contributors permission to add labels in the upstream repository. Maintainers: please applyllm-generatedduring triage.