Skip to content

chore(ci): label FTC-closed PRs as needs-issue - #7249

Open
Vidit-Ostwal wants to merge 2 commits into
mainfrom
chore/ftc-needs-issue-label
Open

chore(ci): label FTC-closed PRs as needs-issue#7249
Vidit-Ostwal wants to merge 2 commits into
mainfrom
chore/ftc-needs-issue-label

Conversation

@Vidit-Ostwal

Copy link
Copy Markdown
Contributor

Related issue

N/A — follow-up to the first-time contributor issue gate.

Summary

  • Created the needs-issue label on crewAIInc/crewAI.
  • The FTC workflow now applies that label before closing first-time contributor PRs that do not mention an open issue.
  • Raised the workflow issues permission to write so labeling works on closed PRs.

Verification

  • Tests added or updated for the changed behavior
  • Relevant tests and quality checks pass locally (uv run pytest lib/crewai/tests/ci/test_ftc_require_issue.py)

Additional context

Filter auto-closed FTC PRs with is:pr is:closed label:needs-issue.

@github-actions github-actions Bot added the size/S label Sep 3, 2026
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: f828a026-4275-4ab8-8059-3ac5ef20476d

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe8317 and 0962984.

📒 Files selected for processing (4)
  • .github/CONTRIBUTING.md
  • .github/pull_request_template.md
  • .github/workflows/ftc-require-issue.yml
  • lib/crewai/tests/ci/test_ftc_require_issue.py
🚧 Files skipped from review as they are similar to previous changes (4)
  • .github/workflows/ftc-require-issue.yml
  • lib/crewai/tests/ci/test_ftc_require_issue.py
  • .github/pull_request_template.md
  • .github/CONTRIBUTING.md

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The first-time contributor workflow now adds the needs-issue label before closing pull requests without a valid open issue. Contributor documentation and regression tests describe and verify the new behavior.

Changes

First-time contributor issue enforcement

Layer / File(s) Summary
Label invalid issue pull requests
.github/workflows/ftc-require-issue.yml
The workflow requests issues: write permission and adds the needs-issue label before closing pull requests without a valid open issue.
Document and test label behavior
.github/CONTRIBUTING.md, .github/pull_request_template.md, lib/crewai/tests/ci/test_ftc_require_issue.py
Contributor guidance includes the automatic label behavior. Tests verify that valid references do not add the label and foreign-repository references do add it.

Merge Risk: ⚪ Minimal · up to 09629

The workflow now labels and closes first-time contributor pull requests without a valid open issue reference, with accompanying documentation and regression coverage. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (3 skipped: 3 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: labeling first-time-contributor PRs that are closed for lacking an issue reference.
Description check ✅ Passed The description includes all required sections. It explains the workflow change, identifies the verification command, confirms tests and quality checks, and provides additional context. The Related is…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (3 skipped: 3 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ftc-needs-issue-label

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant