fix: remove broken agent - #137
Conversation
|
@ryancormack unfortunately I had an error in the github actions workflow resulting in env variables not properly set for PRs from forked repos. Can you please rebase the changes? That also applies for PR #138 |
d2050aa to
a72472f
Compare
- If files are deleted, they won't exist on disk and then there are no authors to check in the markdown files
|
Thanks. I created an issue to fix the false assumptions in the content validation script. Will merge this PR and send you another round of "huuuuge thank you" 🤩 |
| with: | ||
| script: | | ||
| const authors = JSON.parse('${{ steps.author-check.outputs.result }}'); | ||
| const authors = JSON.parse('${{ steps.author-check.outputs.result }}' || '[]'); |
There was a problem hiding this comment.
The previous step, https://github.com/cremich/promptz/blob/main/.github/workflows/content-validation.yml#L64 returns false if files have only been deleted (not changed or added), https://github.com/tj-actions/changed-files?tab=readme-ov-file#output_any_changed
So there is no JSON object to parse. This guards against that by always having an array to check against. Then count the numbers before posting to github
|
Started writing why I made those changes, but see you've merged. Ta very much |
2 participants
What type of change does this PR contain?
Remove a broken agent
Please select the appropriate template for your pull request:
Click on the link above that matches your change type to use the appropriate template.