Skip to content

ci: add manual OCR integration workflow - #90

Merged
Helio-206 merged 1 commit into
prodfrom
test/72-ocr-integration-workflow
Aug 17, 2026
Merged

ci: add manual OCR integration workflow#90
Helio-206 merged 1 commit into
prodfrom
test/72-ocr-integration-workflow

Conversation

@Helio-206

Copy link
Copy Markdown
Collaborator

What changed

  • add a manual workflow_dispatch job for the real PaddleOCR integration test;
  • install the OCR service dependencies in a Python 3.11 runner;
  • document the local command and the intentional separation from deterministic PR checks.

Why

The required OCR CI suite must remain deterministic and fast, while the real
PaddleOCR engine requires model downloads and is slower. This workflow makes
that integration proof reproducible on demand without making pull requests
depend on external model downloads.

Validation

  • git diff --cached --check
  • GitHub Actions YAML parsed locally with Ruby's YAML parser
  • local full OCR execution not run: this checkout does not have pytest and
    pydantic-settings installed; the workflow installs the declared dependencies

This partially addresses #72. The issue remains open for the complete OCR test
matrix, coverage evidence, and remaining contract/integration work.

@Helio-206
Helio-206 marked this pull request as ready for review August 17, 2026 19:43
@Helio-206
Helio-206 merged commit 3a57842 into prod Aug 17, 2026
2 checks passed
@Helio-206
Helio-206 deleted the test/72-ocr-integration-workflow branch August 17, 2026 19:44

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3be3527b33

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

run: python -m pip install --upgrade pip && python -m pip install -r requirements.txt

- name: Run real OCR integration tests
run: python -m pytest -m integration --runintegration --runslow -v

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fail the workflow when real OCR returns an error

When model download, initialization, or the actual OCR call fails, this workflow still reports success: the selected integration test calls process_image, which converts every exception into an OCRResult(status="error"), and then explicitly accepts "error" as a valid status in tests/test_engine.py:614-618. Consequently, the new manual workflow cannot provide the advertised real-engine integration proof; the test should require successful OCR output or otherwise propagate the failure.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant