Ensure last entry in keymap popup is displayed

[winny-]

The downside is there appears to be a blank line at the bottom of the keymap
popup. If there is another way to ensure the last line is included in the
popup without adding a blank line, that solution would be ideal. Because of
this nitpick, I marked this PR as a draft.

[crater2150]

Could you describe the problem you're seeing without this? For me, there are no missing lines in the popup. Do you use customized positioning?

[winny-]

Sorry for the delay. Thank you for the feedback! :)

Below are some screenshots highlighting the issue this PR attempts to solve. I've also attached some version information at the very end.

I've also linked my current configs (see modal.lua in particular), though I intend on trying to reproduce the issue in Xephyr with a reduced awesome config. I hope to have this tested in such a way for this weekend.

I hope this helps clarify the weird issue I've encountered. As mentioned above, I'm not entirely certain this is the best way to address the issue. I'm looking forward to better understanding what's going on here.

Screenshots

In the next two screenshots the very bottom will show a key entry in the first screenshot, which is present in the second screenshot.

Here's a screenshot of what happened on my present setup without this commit:

Here's the same modal with the git commit applied:

Version information

winston@snowcrash ~/.../awesome/modalbind $ awesome --version
awesome v4.3 (Too long)
 • Compiled against Lua 5.1.5 (running with Lua 5.1)
 • D-Bus support: ✔
 • execinfo support: ✔
 • xcb-randr version: 1.6
 • LGI version: 0.9.2
winston@snowcrash ~/.../awesome/modalbind $ uname -a
Linux snowcrash 5.7.13 #1 SMP Wed Aug 12 03:22:48 CDT 2020 x86_64 AMD FX(tm)-8350 Eight-Core Processor AuthenticAMD GNU/Linux

[crater2150]

I experimented a bit with your config and noticed, that the problem only occurs, if there is only a single entry after the last separator. Also, the problem seems to be that the whole text is then placed lower inside the wibox. This is also visible in your screenshots, the one with the missing entry has more space above the "Manage Awesome" title.
May be related to: awesomeWM/awesome#3126

The only other solution I've found is to add at least 2 pixels to the height here. But 2 pixels seems arbitrary and is probably dependent on font/dpi/whatever else, so I wouldn't say that workaround is any better...