Project: Remove spec.required_ruby_version#53
Merged
Conversation
amotl
force-pushed
the
rm-required-ruby-version
branch
from
4238dff to
d9cc94f
Compare
amotl
commented
Feb 10, 2026
|
|
||
| AllCops: | ||
| NewCops: enable | ||
| TargetRubyVersion: 2.5 |
Contributor
Author
There was a problem hiding this comment.
rubocop doesn't like it.
Gemspec/RequiredRubyVersion: required_ruby_version should be specified.
Contributor
Author
There was a problem hiding this comment.
Solved using this snippet in .rubocop.yml.
Gemspec/RequiredRubyVersion:
Enabled: false
It might prevent Dependabot from working properly. Because rubocop >= 1.51.0 depends on Ruby >= 2.7.0 and Gemfile depends on rubocop = 1.84.1, Ruby >= 2.7.0 is required. So, because current Ruby version is = 2.5.9, version solving has failed. -- https://github.com/crate/crate_ruby/network/updates/1239572576 The README also says "You will need Ruby 2.0 or greater."
amotl
force-pushed
the
rm-required-ruby-version
branch
from
d9cc94f to
ec6a957
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
-- https://github.com/crate/crate_ruby/network/updates/1239572576
Thoughts
The version constraint might prevent Dependabot from working properly. A library should support many upstream and downstream software versions anyway, so removing the constraint makes sense also from that perspective.
The README also says "You will need Ruby 2.0 or greater."