Support restoring a snapshot from an AWS S3 bucket with an endpoint URL - #889
Merged
Conversation
juanpardo
approved these changes
Aug 24, 2026
juanpardo
left a comment
juanpardo
left a comment
Contributor
There was a problem hiding this comment.
Approved it but added a small question :P
| except KeyError: | ||
| raise kopf.PermanentError(f"Key {key} not found in secret.") | ||
| if BackupRepositoryData.is_optional(backup_provider, key): | ||
| data_dict[key] = "" |
Contributor
There was a problem hiding this comment.
Is the entry really needed at all?
If so, perhaps a None would make more sense than an empty string, if it's allowed.
Otherwise, I would not add the key.
Contributor
Author
There was a problem hiding this comment.
It is to keep in consistent with the other fields of AwsBackupRepositoryData that have type str and not Optional[str]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Support restoring a snapshot from an S3-compatible bucket with a custom endpoint URL.
Previously the endpoint_url was ignored.
Checklist
CHANGES.rst