change: Migrate static analysis to Mago#28
Merged
Conversation
remipelhate
force-pushed
the
change/migrate-static-analysis-to-mago
branch
from
1593e50 to
334961a
Compare
remipelhate
force-pushed
the
change/migrate-static-analysis-to-mago
branch
from
334961a to
1a185cf
Compare
remipelhate
force-pushed
the
change/migrate-static-analysis-to-mago
branch
2 times, most recently
from
c3d3c50 to
ef441a3
Compare
remipelhate
force-pushed
the
change/migrate-static-analysis-to-mago
branch
from
ef441a3 to
d3e79d6
Compare
This was implementated to allow using the constraint on Laravel’s TestResponse object. However, there is no need for it. This can be solved by passing $response->json() instead of the TestResponse instance.
remipelhate
force-pushed
the
change/migrate-static-analysis-to-mago
branch
from
5785cd9 to
e17e2cf
Compare
fowbi
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces PHPCS Fixer, PHPStan and Rector with Mago in order to simplify our tooling setup. No more separate configuration files for the different static analysers, everything is defined in
mago.toml. In addition, Mago runs much faster than any of these other static analysis tools, both locally and within workflows.Important
Mago is less "flexible" than some of its alternatives and strictly enforces PER-CS coding standards. This means that some of the internals may be formatted slightly differently from what we're used to. Changes made to the internals were done to fix the reported issues, though I believe some of them could be refactored slightly better (but that was not the goal in this PR).