Adding code to clear Spring contexts before/after site context init

[avasquez614]

craftercms/craftercms#8734

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0a33f7c6-fa93-4a2f-a17f-be7bddce19fb

📥 Commits

Reviewing files that changed from the base of the PR and between ba965dd and e12a5ce.

📒 Files selected for processing (1)

• src/main/java/org/craftercms/engine/service/context/SiteContext.java

---

Summary by CodeRabbit

• Bug Fixes
  • Improved thread context handling in maintenance task execution to prevent context isolation issues between concurrent operations.

Walkthrough

SiteContext now configures its maintenance task executor using a custom ThreadPoolExecutor that clears Spring request and locale thread contexts before and after each maintenance task execution, replacing the previous plain Executors.newSingleThreadExecutor(). Error logging is centralized in the afterExecute hook.

Changes

Spring Thread Context Cleanup for Maintenance Executor

Layer / File(s)	Summary
Maintenance executor with Spring thread context cleanup src/main/java/org/craftercms/engine/service/context/SiteContext.java	Imports for LocaleContextHolder and RequestContextHolder are added; SiteContext constructor delegates executor creation to a new createMaintenanceTaskExecutor() factory method that configures a single-thread executor with beforeExecute/afterExecute hooks to clear Spring thread-bound contexts before and after task execution; centralized error logging in afterExecute when tasks fail.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• sumerjabri

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only contains a GitHub issue link without explaining what the PR does, why it's needed, or how it solves the problem.	Expand the description to explain the issue being fixed, the solution implemented, and any relevant context or testing information.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding code to clear Spring contexts before/after site context initialization, which aligns with the file summary showing ThreadPoolExecutor clearing request and locale contexts.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}