Skip to content

Add missing test coverage for NewMockParams fields#141

Merged
yegor256 merged 2 commits into
138.afrom
copilot/sub-pr-139-again
Dec 13, 2025
Merged

Add missing test coverage for NewMockParams fields#141
yegor256 merged 2 commits into
138.afrom
copilot/sub-pr-139-again

Conversation

Copilot AI commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

Addresses review feedback requesting complete test coverage for all fields set by NewMockParams().

Changes

  • Added tests for previously uncovered fields:
    • Playbook (empty string)
    • Soutput ("stats")
    • Input (empty string)
    • Output (empty string)

Each test follows the existing pattern of individual test functions per field for consistency with the codebase style.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI self-assigned this Dec 13, 2025
Co-authored-by: yegor256 <526301+yegor256@users.noreply.github.com>
Copilot AI changed the title [WIP] Work in progress to address feedback on params.go test Add missing test coverage for NewMockParams fields Dec 13, 2025
Copilot AI requested a review from yegor256 December 13, 2025 05:31
@yegor256 yegor256 marked this pull request as ready for review December 13, 2025 05:34
Copilot AI review requested due to automatic review settings December 13, 2025 05:34
@yegor256 yegor256 merged commit fc11dd6 into 138.a Dec 13, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive test coverage for the NewMockParams() function by adding tests for four previously untested fields. The PR addresses review feedback requesting complete coverage of all fields initialized by the mock params constructor.

  • Added four new test functions following the existing single-field test pattern
  • Tests verify empty string defaults for Playbook, Input, and Output fields
  • Tests verify Soutput is correctly set to "stats"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants