Add edge case tests for mask function boundary conditions#140
Merged
Conversation
Merged
Co-authored-by: yegor256 <526301+yegor256@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on new test for params.go
Add edge case tests for mask function boundary conditions
Dec 13, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive edge case tests for the mask function to ensure correct behavior at critical boundary conditions. The mask function is used to safely display API tokens in logs by showing only the first 3 characters and replacing the rest with asterisks.
- Adds three new test cases covering lengths 1, 3, and 4 characters
- Tests the transition point where masking begins (tokens with more than 3 characters)
- Complements existing tests for empty strings, 2-character tokens, and long tokens
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #139 to add missing edge case tests for the
maskfunction, which masks API tokens by showing the first 3 characters and replacing the rest with asterisks.Changes
These tests cover critical boundary conditions in the masking logic:
The new tests ensure correct behavior at the transition points where the function switches from no masking (≤3 chars) to progressive masking (>3 chars).
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.