Skip to content

fix(install): prune once per event — second hook on a shared event was silently dropped #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tespera wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(install): prune once per event — second hook on a shared event was silently dropped #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,19 @@ if mode == "uninstall":
print("fable-mode hooks removed from %s" % settings_path)
sys.exit(0)

# install: prune our old entries first (handles moves/upgrades), then add fresh.
# install: prune our old entries first (handles moves/upgrades), then add
# fresh. Prune ONCE per event before appending — pruning inside the append
# loop would strip the groups just added for an earlier spec on the same
# event (two hooks share PostToolUse/Bash).
added = 0
for event in {e for e, _, _ in SPECS}:
hooks[event] = prune(hooks.get(event, []))
for event, matcher, fname in SPECS:
entries = prune(hooks.get(event, []))
group = {"hooks": [{"type": "command",
"command": "python3 %s" % os.path.join(hooks_dir, fname)}]}
if matcher:
group["matcher"] = matcher
entries.append(group)
hooks[event] = entries
hooks[event].append(group)
added += 1

data["hooks"] = hooks
Expand Down