Update: EA Tools based on Murtadha's recommendation - #253
Merged
VirajAgarwal-couchbase merged 4 commits intoSep 1, 2026
Conversation
VirajAgarwal-couchbase
marked this pull request as ready for review
September 1, 2026 09:07
VirajAgarwal-couchbase
requested review from
SanjanaBoggaramJ
and
a lite review from Copilot
September 1, 2026 09:07
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Pull request overview
Updates the Enterprise Analytics (EA) metadata tools to align schema inference with Analytics’ built-in ARRAY_INFER_SCHEMA behavior and makes the associated tests less coupled to a specific response envelope.
Changes:
- Switch
get_schema_for_collectionfrom custom per-field inference toARRAY_INFER_SCHEMA, returning the inferred “flavor” objects. - Extend
get_collections_in_scoperesults to include datasetType(DatasetType). - Update unit/integration tests to reflect the new schema inference output and avoid over-asserting the envelope shape.
File summaries
| File | Description |
|---|---|
| analytics-mcp/src/ea_mcp/tools/metadata.py | Uses ARRAY_INFER_SCHEMA for schema inference and includes dataset type in collection listings. |
| analytics-mcp/tests/unit/test_metadata_tools_unit.py | Updates unit expectations for the ARRAY_INFER_SCHEMA-based return shape. |
| analytics-mcp/tests/integration/test_metadata_tools.py | Makes schema assertions resilient to envelope changes by checking presence of inferred field keys. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SanjanaBoggaramJ
left a comment
Contributor
There was a problem hiding this comment.
Here in the comment uve mentioned that the sample_size must be
positive and is capped at MAX_SCHEMA_SAMPLE_SIZE, but when the agent is reading this it, it wont know the number right?
SanjanaBoggaramJ
approved these changes
Sep 1, 2026
SanjanaBoggaramJ
approved these changes
Sep 1, 2026
SanjanaBoggaramJ
approved these changes
Sep 1, 2026
VirajAgarwal-couchbase
merged commit Sep 1, 2026
38599ca
into
DA-2027/Add-enterprise-tools
3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Murtadha's recommendations in EA tools
Evidence of Testing
Environments tested (both are required):
Checklist
cb_mcp.corecontracts / managed MCP interfaces (or discussed first)