feat: state the device's own address in origin.ip - #60
Merged
Conversation
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
Comment |
Contributor
Author
|
@coderabbitai review |
|
DavidCozens
force-pushed
the
stage-11-origin
branch
from
August 16, 2026 17:57
ef4f510 to
4ca933f
Compare
Contributor
Author
|
@coderabbitai pause |
The ip PARAM, sourced from the same interface address HOSTNAME reports. A relay or NAT between device and collector rewrites what the collector observes; ip is what the device says about itself, which survives the hop. Flash +12,380 B (+392 on the previous stage) RAM +9,172 B (unchanged) Log stack +680 B (+8) Service +960 B (unchanged) ip is repeatable, so the library asks for a count and then one value per index rather than taking a string. This device has one address and returns one, and none before the interface has an address — a count of zero omits the PARAM rather than emitting an empty one. SyslogFields_IpAddress is now the single place that reads the address, and HOSTNAME formats the same string through it, so two fields that must agree cannot disagree. Four elements put the record at 260 octets. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DavidCozens
force-pushed
the
stage-12-origin-ip
branch
from
August 16, 2026 17:57
6dd39b1 to
d3d292e
Compare
✅ Action performedReviews paused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
ipPARAM to the origin element, sourced from the same interface address the HOSTNAME fieldreports.
A relay or NAT between the device and the collector rewrites the address the collector observes.
ipis what the device says about itself, and that survives the hop.
The PARAM is repeatable, so the library asks for a count and then one value per index rather than
taking a single string. This device has one address and returns one, and returns none before the
interface has an address — a count of zero omits the PARAM rather than emitting an empty one.
SyslogFields_IpAddressbecomes the single place that reads the address, and HOSTNAME formats thesame string through it. Two fields that must agree now cannot disagree.
Four elements put the record at 260 octets.