feat: install the SolidSyslog error handler - #2
Merged
Conversation
Contributor
Author
|
@coderabbitai pause |
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
✅ Action performedReviews paused. |
Nothing in the library fails loudly. A _Create that cannot succeed substitutes a Null object and reports it rather than returning NULL, so a logger that has silently stopped looks exactly like one with nothing to say. The handler is what tells them apart, and it goes in before the first _Create rather than after something looks wrong. Flash +412 B RAM +8 B The handler prints to the same console as everything else, so a fault lands in the run report next to the rest of what the device did. It names the four lifecycle categories a misconfigured integration raises and prints the rest numerically — a device reacting to those would switch on the category, not the text. It is more than an integration aid. The handler is the seam into the device's own error and health reporting, and later stages use it at run time: an edge-triggered warning when the collector becomes unreachable, a notice when delivery recovers. The build gains one source file and its include directory. Nothing about how SolidSyslog enters the build changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DavidCozens
force-pushed
the
stage-02-error-handler
branch
from
August 16, 2026 21:46
b3ac316 to
697c5e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install the handler before any other call into SolidSyslog.
Nothing in the library fails loudly. A
_Createthat cannot succeed substitutes a Null object andreports it rather than returning
NULL, so a logger that has silently stopped looks exactly likeone with nothing to say. The handler is what tells the two apart, which is why it goes in before
the first
_Createand not after something looks wrong. It reports many misconfiguration errors,and can save significant time while integrating.
This is not only an integration aid. The handler is the seam into the device's own error and health
reporting, and it stays valuable at run time: later stages raise an edge-triggered warning when the
collector becomes unreachable and a notice when delivery recovers. Route it wherever the device
already routes faults — here, the same console as everything else, so a fault lands in the run
report next to the rest of what the device did.
The handler names the four lifecycle categories a misconfigured integration raises and prints the
rest numerically. A device reacting to a fault would switch on the category rather than the text.
When you need it. Every device, and first. It is the only thing standing between a
misconfigured logger and a silent one.
The build gains one source file and its include directory. Nothing about how SolidSyslog enters
the build changes.