feat: present a client certificate for mutual TLS - #16
Merged
Conversation
Contributor
Author
|
@coderabbitai pause |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
Comment |
✅ Action performedReviews paused. |
DavidCozens
force-pushed
the
stage-15-pipeline-sd
branch
from
August 16, 2026 21:51
29a36ee to
bfc82fd
Compare
ClientCertChain and ClientKey join the stream config, and the collector moves to 6515. The device authenticates itself to the collector as well as verifying it. Flash +13,624 B (+68 on the previous stage) RAM +39,524 B (+2,052) mbedTLS peak +15,892 B (37,220 absolute) Log stack +680 B (unchanged) Service +3,768 B (unchanged) Both handles come from the cert store, which has parsed them since boot, so no provisioning or parsing is charged here. The mbedTLS pool moves from 53 to 55 KiB, following this device's existing rule of peak times 1.5 rounded up to the next KiB. The run passes without the resize; the margin is for fragmentation. Both credentials must be set: either one NULL disables mTLS and the connection falls back to server authentication without failing. The pipeline element is therefore given what the device holds rather than what was configured. Port 6515 requires a client certificate, and scripts/smoke-oracle.sh shows it refusing a client that presents none. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DavidCozens
force-pushed
the
stage-16-mtls
branch
from
August 16, 2026 21:51
6eb1562 to
e0b507e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a client certificate and its key to the stream config. The handshake then authenticates the
device to the collector, as well as the collector to the device.
Both fields must be set. Supplying one and not the other leaves the connection
server-authenticated and does not fail, so the pipeline element is given what the device holds
rather than what was configured:
The handshake authenticates the TLS peer. Where a relay, gateway or broker terminates the
connection, the collector authenticates that hop rather than the device behind it, and the
originelement carries the device's own identity across it.
The collector port used here requires a client certificate and refuses a client that presents none.
When you need it. When the receiver has to authenticate the device rather than accept the
identity the record claims. It requires a certificate per device, protected storage for the private
key, and an issuing and revocation process behind both.