feat: identify the device with an origin SD-ELEMENT - #11
Merged
Conversation
Contributor
Author
|
@coderabbitai pause |
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
Comment |
✅ Action performedReviews paused. |
DavidCozens
force-pushed
the
stage-10-file-store
branch
from
August 16, 2026 21:49
d168480 to
b378798
Compare
SolidSyslogOriginSd carrying software, swVersion and enterpriseId. Flash +11,988 B (+392 on the previous stage) RAM +9,168 B (+44) Log stack +672 B (unchanged) Service +960 B (unchanged) It lands after the store rather than before it. While a record went straight out, the answer to "who sent this" was implied by the connection it arrived on; once records can replay hours later that is no longer so, and the record has to carry it. The ip PARAM is left out. The address the collector sees is still the address that reached it, and the next stage is what takes that assumption away. SYSLOG_ENTERPRISE_ID is defined in app/syslog/SyslogEnterprise.h rather than beside the element that carries it, because the number identifies the vendor rather than the logger — anything else this product puts its own name on wants the same one, and one definition cannot drift from itself. 32473 is reserved for documentation and testing by RFC 5612; a shipping product uses its own, registered with IANA. Three elements put the record at 245 octets. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
DavidCozens
force-pushed
the
stage-11-origin
branch
from
August 16, 2026 21:50
20f631b to
5b7204c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name the device in the record with
SolidSyslogOriginSd— the software, its version, and theenterprise number.
This lands after the store rather than before it. While records went straight out, the answer to
"who sent this" was implied by the connection they arrived on. Once records can replay hours later
that is no longer so, and the record has to carry it.
The
ipPARAM is left out here. The address the collector sees is still the address that reachedit; the next stage takes that assumption away.
SYSLOG_ENTERPRISE_IDis defined in its own header rather than beside the element that carries it,because the number identifies the vendor rather than the logger — anything else this product puts
its own name on wants the same one.
When you need it. If records will be correlated across devices, replayed after a delay, or
relayed through anything.