Skip to content

Fix config object items method when there are defaults and defaults=False #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joezuntz merged 1 commit into from
Mar 9, 2026
Merged

Fix config object items method when there are defaults and defaults=False #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cosmosis/runtime/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ def _interpolate_compatibility(self, section, option, value, d):
elif hasattr(self, "_interpolate"):
return self._interpolate(section, option, value, d)
else:
d = self._unify_values(section, {})
return self._interpolation.before_get(self, section, option, value, d)


Expand Down
16 changes: 15 additions & 1 deletion cosmosis/test/test_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import numpy as np
import tempfile
import os
import io

def test_override_new():
with tempfile.NamedTemporaryFile('w') as values:
Expand Down Expand Up @@ -97,4 +98,17 @@ def test_items():
ini.set("parameters", "p1", "-3.0 0.0 3.0")
ini.set("parameters", "p2", "-3.0 0.0 3.0")
ini.items("parameters", defaults=True)
ini.items("parameters", defaults=False)
ini.items("parameters", defaults=False)

def test_items_with_defaults():
sio = io.StringIO("""
[DEFAULT]
x = 1
[parameters]
y = 2
""")
ini = Inifile(sio)
assert ini.getint("parameters", "y") == 2
assert ini.getint("parameters", "x") == 1
assert dict(ini.items("parameters", defaults=True)) == {"x": "1", "y": "2"}
assert dict(ini.items("parameters", defaults=False)) == {"y": "2"}
Loading