feat(cli): render config improvements - #1431
Open
dhfang wants to merge 4 commits into
Open
Conversation
Signed-off-by: Dennis Fang <dhsfang@gmail.com>
Signed-off-by: Dennis Fang <dhsfang@gmail.com>
Contributor
Greptile SummaryThe PR changes
Confidence Score: 4/5The PR is not yet safe to merge because population can successfully overwrite the config with an undeclared chain that lacks its required RPC endpoint. The attempted fix validates only after writing and treats validation failure as a warning, so the previously reported incomplete-chain configuration remains persisted and unusable. Files Needing Attention: cli/cmd/ibc/deploy.go, cli/cmd/ibc/deploy_test.go Important Files Changed
Reviews (2): Last reviewed commit: "report populate status on stderr and war..." | Re-trigger Greptile |
Signed-off-by: Dennis Fang <dhsfang@gmail.com>
Contributor
Author
|
@greptile re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--populate-configflag writes the result to the config file. Without--yesit prints the config it would write, lists what that changes, and asks before writing.closes fou-1473