Skip to content

fix(link): deploy: mention dry run in logs - #1414

Merged
swift1337 merged 1 commit into
fix/proto-json-casingfrom
fix/deploy-gmp
Aug 25, 2026
Merged

fix(link): deploy: mention dry run in logs #1414
swift1337 merged 1 commit into
fix/proto-json-casingfrom
fix/deploy-gmp

Conversation

@swift1337

Copy link
Copy Markdown
Member

Stack created with GitHub Stacks CLIGive Feedback 💬

@swift1337
swift1337 requested a review from a team as a code owner August 21, 2026 13:17
@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds the deployment execution mode to each step runner’s structured logger so preview and real-execution records can be distinguished.

  • Attaches dryRun=true to deployment preview logs.
  • Attaches dryRun=false to actual execution logs.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or quality issues identified.

The added structured attribute accurately reflects each RunSteps invocation, and every current caller supplies a valid logger without a conflicting dryRun attribute.

Important Files Changed

Filename Overview
link/internal/deploy/steps.go Derives a per-invocation logger carrying the dry-run mode before processing deployment steps; no actionable defect identified.

Reviews (1): Last reviewed commit: 635ec76 | Re-trigger Greptile

@swift1337
swift1337 force-pushed the fix/deploy-gmp branch 2 times, most recently from 88eb7d1 to 78769c9 Compare August 25, 2026 10:28
@swift1337
swift1337 merged commit 063a6c8 into main Aug 25, 2026
29 of 36 checks passed
@swift1337
swift1337 deleted the fix/deploy-gmp branch August 25, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants