feat(besu): add IBFT 2.0 and QBFT light clients - #1092
Conversation
50b870e to
6b57741
Compare
3cfe0a8 to
812898f
Compare
|
Tick the box to add this pull request to the merge queue (same as
|
Greptile SummaryThe PR adds Solidity light clients and proof-service support for Besu IBFT 2.0 and QBFT networks, together with generated bindings, fixtures, and end-to-end infrastructure.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up review scope. No blocking failure remains. Important Files Changed
|
812898f to
e7f8629
Compare
117726e to
8abcbfb
Compare
8abcbfb to
227c1da
Compare
691208e to
fe40ccb
Compare
|
@greptile review |
fe40ccb to
0f7ad52
Compare
srdtrk
left a comment
There was a problem hiding this comment.
First pass. I'm still reviewing the proof api code
| command: | ||
| - --config-file=/opt/besu/config.toml | ||
| - --identity=validator1 | ||
| - --p2p-host=10.42.0.2 |
There was a problem hiding this comment.
This is cool. It does feel a bit weird that we have to hard code IPs, number of validators, and the images used. Maybe this file should be generated from a template?
There was a problem hiding this comment.
we can consider it, for now i left it since besu requires deterministic addresses
| Some( | ||
| self.src_listener | ||
| .get_block_number() | ||
| .await | ||
| .map_err(to_tonic_status)?, | ||
| ) |
There was a problem hiding this comment.
smarter thing to do is to get this by parsing the timeout events, getting the timestamp and then converting it to a height. However, I understand that it might be cumbersome. If we can modify proof API to use timestamps for timeouts rather than block heights, that might be more ideal.
There was a problem hiding this comment.
yeah, might be worth considering, but in the proof api as it is, i dont think it is worth doing rn (perhaps in ibc "link")
| pub src_ics26_address: Address, | ||
| pub dst_rpc_url: String, | ||
| pub dst_ics26_address: Address, | ||
| pub consensus_type: BesuConsensusType, |
There was a problem hiding this comment.
I wonder if we can query the chains to figure this out to remove the need for this config param. Would improve the UX a lot imo.
There was a problem hiding this comment.
would. we should look into it when we move this over to link
8a4808b to
f023bca
Compare
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
Signed-off-by: Gjermund Garaba <gjermund@garaba.net>
8c60f75 to
6abf71c
Compare
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Signed-off-by: srdtrk <srdtrk@hotmail.com>
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.