fix(web): prevent workspace path traversal via prefix bypass - #88
Open
Tamsi wants to merge 1 commit into
Open
Conversation
Replace startsWith(root) checks with path.relative-based validation so sibling directories (e.g. mercury vs mercury-private) cannot be read, written, or used as terminal cwd. Also validate git unstage paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolved.startsWith(root)incorrectly allows access to sibling directories (e.g. workspace/home/user/mercuryvs path../mercury-private/secret.env).isPathInsideRoot()usingpath.relative()(same idea already used inskills/store.tswithroot + sep).cwd, git stage/unstage.mercuryvsmercury-privatebypass case.Impact
An authenticated web user could previously read/write files outside the configured workspace, list adjacent directories, run shell commands with a
cwdoutside the workspace, and stage/unstage arbitrary paths via git.Test plan
npm test— all 71 tests pass (including 4 newpath-safetytests)npm run typecheckpassesGET /api/workspace/file?path=../<sibling-dir>/filereturns 403PUT /api/workspace/filewith../<sibling-dir>/filereturns 403