fix(permissions): deny safe-read auto-approval for shell redirections - #85
Open
SeashoreShi wants to merge 1 commit into
Open
fix(permissions): deny safe-read auto-approval for shell redirections#85SeashoreShi wants to merge 1 commit into
SeashoreShi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
>,>>, and heredoc redirections while preserving quoted / escaped literalsWhy
checkShellCommand()currently auto-approves commands when every parsed segment matches a safe-read pattern likecat *. That still treats commands such ascat README.md > variant.txtas read-only even though the execution path later runs the original command withshell: true, letting the shell perform a write redirection.This change keeps the current permission model but prevents safe-read auto-approval whenever a segment contains unquoted redirection syntax.
Testing
npm test -- src/capabilities/permissions.test.tsnpm run typecheck