fix(dicomImageLoader): Fix expected number of LUT entries when tag value is 0 - #2876
fix(dicomImageLoader): Fix expected number of LUT entries when tag value is 0#2876abustany wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe DICOM LUT parser now interprets an encoded entry count of zero as 65,536 entries, matching the DICOM specification. ChangesDICOM LUT parsing
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: ⚪ Minimal · up to This localized fix corrects LUT entry handling for a DICOM value of 0; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
already adressed by this PR #2856 |
Context
The code was incorrectly interpreting value
0as65535instead of65536, unlike what DICOM PS3.3 C.11.1.1.1 specifies.Changes & Results
Fixed the code -> file now decodes fine.
Testing
Tested with an XRay file from a GE scanner I unfortunately can't share here.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
Summary by CodeRabbit