feat(core): improve WSI overview map interactions - #2871
Closed
benjaminforras wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Whole-slide microscopy viewports already render an overview map, but its controls can pass pointer and wheel events to viewport tools. The magnification box also cannot pan the main slide. Replacing WSI data in the legacy viewport loses the collapsed state and can leave document drag listeners attached.
This keeps the overview-map change separate from #2870, which covers right-drag region zoom.
Changes & Results
WSIViewportreplaces its data.Before, overview interactions could activate viewport tools, dragging the magnification box did not pan the slide, and WSI replacement could leave stale listeners.
After, overview interactions remain within the control, drag-to-pan works, and the interaction state follows the WSI lifecycle.
Testing
Automated checks:
corepack pnpm exec jest --selectProjects core packages/core/test/wsiOverviewMapInteractions.jest.js --runInBand: 34 suites passed, 552 tests passed, 2 skipped.pnpm run build: passed for the workspace.pnpm run lint: passed with no warnings or errors.pnpm run test:ci: passed in Chrome Headless.Manual verification steps:
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals. No documentation change is needed because this changes existing overview-map behavior without adding a user-facing option.
Tested Environment