fix(dicomImageLoader): normalize stored pixel bits - #2868
Conversation
Mask unsigned pixels to Bits Stored before range calculation. Use High Bit to locate the stored field and preserve signed values. Fix rendering when unused upper bits contain nonzero data. Fixes cornerstonejs#781
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan includes up to 4 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe change adds optional HighBit metadata, centralizes stored pixel normalization, applies it during decoded-pixel post-processing, and adds coverage for masking, shifting, sign extension, and unchanged data. ChangesDecoded pixel normalization
Estimated code review effort: 3 (Moderate) | ~15 minutes Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains; the PR is merge-ready after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jbocce can i have a review? |
Context
Mask unsigned pixels to Bits Stored before range calculation. Use High Bit to locate the stored field and preserve signed values. Fix rendering when unused upper bits contain nonzero data.
Fixes #781
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
Summary by CodeRabbit
Bug Fixes
Enhancements