fix(wsi): stop mouse events leaking from overview map to tools - #2852
Open
daniel-szabo-dev wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesWSI overview-map event isolation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When a WSI viewport is loaded,
@cornerstonejs/toolsattaches raw DOM listeners (mousedown,dblclick,pointerdown) to the viewport element. TheVolumeImageViewerfromdicom-microscopy-viewerrenders an OpenLayers overview map (minimap) inside that same element. Because the minimap is a child of the viewport element, mouse events on it bubble up and fire CS3D tool handlers (e.g. pan, annotations). This is unwanted behaviour, interaction within the minimap should stay within that container.Changes & Results
In
WSIViewport.setWSI(), immediately after constructing theVolumeImageViewer, attachstopPropagationlisteners on the OL overlay container using the public APImap.getOverlayContainerStopEvent(). This element is created synchronously in the OLMapconstructor, so it is available beforeviewer.render()is called.Before: Clicking on the WSI minimap triggers CS3D tool handlers.
After: Interactions with the minimap are contained within the overview map and do not reach the tool handlers.
Testing
Checklist
PR
Code
Public Documentation Updates
Tested Environment