Skip to content
This repository was archived by the owner on Sep 23, 2021. It is now read-only.

Added email sign in option#107

Open
kjasani111 wants to merge 4 commits into
masterfrom
emailSignIn
Open

Added email sign in option#107
kjasani111 wants to merge 4 commits into
masterfrom
emailSignIn

Conversation

@kjasani111

@kjasani111 kjasani111 commented Oct 13, 2020

Copy link
Copy Markdown

Summary
This pull request supports email sign in through Firebase UI. It also removes Google sign-in. This will hopefully fix the issue with Apple where we were required to add Apple sign-in if we had Google sign-in in order to push to the app store.

How it works now

  • When the user presses 'get started,' a getStarted method is triggered that presents a Firebase UI window where the user can sign in with their email address.
  • The Firebase UI comes with an authentication extension that was added to the LogIn view controller that automatically checks whether the user had an account previously or not, and automatically creates an account with the user's email, or logs the user in to their existing account.
  • The uid of the logged in user is passed into the get server auth token, which validates the token and returns another token generated by Django. If this token is valid, then the user is successfully logged in.
  • In order to implement these changes, I had to update the API key (the other one was expired).

Test Plan
-The test plan is to run the new sign in with the backend server and see if a servertoken is appropriately generated.

Breaking Changes
-Users will not be using google sign in
Simulator Screen Shot - iPhone 11 - 2020-10-12 at 22 32 44
Simulator Screen Shot - iPhone 11 - 2020-10-12 at 22 32 57

Simulator Screen Shot - iPhone 11 - 2020-10-12 at 22 33 03

@kjasani111
kjasani111 requested a review from a team as a code owner October 13, 2020 02:06
@dti-github-bot

dti-github-bot commented Oct 13, 2020

Copy link
Copy Markdown
Member

[diff-counting] Significant lines: 112.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants